emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Bug: Org-drill defines advice causing infinite recursion [9.3.6 (release


From: Christoffer Stjernlöf
Subject: Bug: Org-drill defines advice causing infinite recursion [9.3.6 (release_9.3.6-465-g4fde1c @ /home/christoffer/.emacs.d/straight/build/org/)]
Date: Thu, 9 Apr 2020 12:19:50 +0200

Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     https://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org mailing list.
------------------------------------------------------------------------

Org-drill defines the following advice:

    (when (version< org-version "9.2")
     (advice-add 'org-get-tags :around #'org-drill-get-tags-advice))

    (defun org-drill-get-tags-advice (orig-fun &rest args)
     ;; the two arg call obsoletes get-local-tags
      (if (= 2 (length args))
         ;; and we don't want any byte compile errors
         (if (fboundp 'org-get-local-tags) (org-get-local-tags))
       ;; the non-arg version doesn't return inherited tags, but
       ;; get-tags-at does.
       (org-get-tags-at)))

The function being called at the end, org-get-tags-at, has the unfortunate definition:

    (define-obsolete-function-alias 'org-get-tags-at 'org-get-tags "Org 9.2")

This results in the advice calling the function it advises, leading to infinite recursion.

Is the version check around the advice addition accidentally inverted? Or is there anything else I'm missing?

Emacs  : GNU Emacs 26.3 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.24.13)
 of 2020-01-28
Package: Org mode version 9.3.6 (release_9.3.6-465-g4fde1c @ /home/christoffer/.emacs.d/straight/build/org/)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]