emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add NO-STATS switch to org-get-heading


From: stardiviner
Subject: Re: [PATCH] Add NO-STATS switch to org-get-heading
Date: Sun, 15 Mar 2020 08:24:41 +0800
User-agent: mu4e 1.3.8; emacs 28.0.50

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256


Adam Porter <address@hidden> writes:

> Please don't add more arguments to org-get-heading.  It used to have 2,
> then it had 4, and now you want to add a 5th.  Every time the function's
> signature changes, it breaks code in third-party packages and user code
> in random places, which requires the addition of messy compatibility
> code and intermediate functions that do nothing but wrap org-get-heading
> with a certain number of arguments.
>
> It would be much preferable to make a new function that uses keyword
> arguments so the addition of more arguments won't affect existing code.
> Maybe it could be called org-entry-heading.

I agree, this statistic cookie is not very necessary for getting headline.
This totally can be done in tools by author self.

- -- 
[ stardiviner ]
       I try to make every word tell the meaning what I want to express.

       Blog: https://stardiviner.github.io/
       IRC(freenode): stardiviner, Matrix: stardiviner
       GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
      
-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5tdckUHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsPq7wgAtr+HkiPHuTmjGsrZaYJkAcTVjwHH
cg+drGKhZmGhADYeR5Sb2fmf8Vghn6DavhxjQrryIAFw5lic9n0DuqgzFe0TP/+Z
SCd8sixjSGqlmjouTcqXgo8QXqPbTJNQyYUwqLYwawyh44LW4AvMFo5UCihr+Mg6
PCDilLMlAV6w0ondqOwaMgbSooU1oZ11jVO5bacgJZzqTeLThMtn0+Cv5b3Lx0lH
j5jnWnJ2HSqYyI96xktWrDU+Wyy2mhKKrHrALl8HNiih3QemSuEJonYt/KsCA3JJ
SzATd0GNGGdg5v5z7k206yOgC+O6ViaeNb070i9I4wRdPDp0FWqHguCMIQ==
=twGf
-----END PGP SIGNATURE-----



reply via email to

[Prev in Thread] Current Thread [Next in Thread]