Re: Bug: org-refile-get-target offers default candidate in duplicity [9.2.6 (9.2.6-4-ge30905-elpaplus @ /home/gustavo/.emacs.d/elpa/org-plus-contrib-20191007/)]

[Gustavo Barros]

Hi Bastien,

On Fri, Feb 14 2020, Bastien wrote:

> I've revisited org-refile-get-location given your new information on
> ivy-completing-read but I'm not able to see something wrong in the
> current implementation of org-refile-get-location.  At the same time,
> I don't see why ivy-completing-read would handle arguments differently
> than completing-read-default, so _perhaps_ org-refile-get-location
> still does something wrong.

That was pretty much my thought too.

> If you - or other ivy users - have time to investigate and report,
> please do so.

I've tried, when I originally reported, and now again, to pin this 
further down.  Alas, there is much in 'org-refile-get-location' I don't 
understand (in the sense of not understanding why certain things are 
being done). I also have much to learn with respect to 
'completing-read'. But I can provide an ECM to reproduce it.

- Start 'emacs -Q'

- Do an initial setup:
 #+begin_src emacs-lisp
 (add-to-list 'load-path "~/src/org-mode/lisp"); current master
 (setq org-refile-targets '(("~/org/test.org" :maxlevel . 2)))
 (setq org-refile-use-outline-path 'file)
 (setq org-outline-path-complete-in-steps nil)
 #+end_src

- Open file "~/org/test.org", with contents:
 #+begin_src org
 ,* Top heading 1
 ,* Top heading 2
 ,** Entry 1
 ,** Entry 2
 #+end_src

- Now, do some refile operations here. Inspecting 'org-refile-history' 
 will give us:
 #+begin_src emacs-lisp
 ("test.org/Top heading 2/" "test.org/Top heading 2/" "test.org/Top 
 heading 1/" "test.org/Top heading 1/")
 #+end_src

- Now, we reset 'org-refile-history' and start 'ivy-mode':
 #+begin_src emacs-lisp
 (setq org-refile-history nil)
 (add-to-list 'load-path ".emacs.d/elpa/ivy-20200211.1338"); current 
 Melpa
 (require 'ivy)
 (ivy-mode)
 #+end_src

- After some refile operations, the value of 'org-refile-history' is:
 #+begin_src emacs-lisp
 ("test.org/Top heading 2" "test.org/Top heading 2" "test.org/Top 
 heading 1" "test.org/Top heading 1")
 #+end_src

The difference is, as previously reported, the presence/absence of the 
trailing slash (the "extra" in terms of 'org-refile-get-location'). As 
far as I can tell, it is inconsequential to the working of the refile 
operation, but it did intrigue me.

Environment: Org mode version 9.3.6 (release_9.3.6-298-g0fa69d @ 
/home/gustavo/src/org-mode/lisp/); GNU Emacs 26.3 (build 1, 
x86_64-pc-linux-gnu, GTK+ Version 3.22.30) of 2019-11-11; 
ivy-20200211.1338

HTH,
Gustavo.