[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface
From: |
stardiviner |
Subject: |
Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface |
Date: |
Fri, 14 Feb 2020 13:24:14 +0800 |
User-agent: |
mu4e 1.3.8; emacs 27.0.50 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
About this patch, last night, I try to test ob-clojurescript eval with CIDER
connection. But no luck, the ClojureScript REPL connection always failed to
start. I have problem on CIDER. So I have a request that can you take a test.
Because on my side, ~(cider-current-connection "cljs")~ returns ~nil~ unable to
test. I think this patch should work. Just for confirm.
Thanks in advance.
Bastien <address@hidden> writes:
> Hi,
>
> stardiviner <address@hidden> writes:
>
>> And patches in attachments.
>
> Applied, thanks.
>
> I made some minor modifications:
>
> - I added the TINYCHANGE cookie in both messages
> - I replaced "ob-clojure.el: (...)" by "ob-clojure.el (...):"
>
> In general, try `C-x 4 a' on a change, either from magit or from
> the modified buffer: this will format a correct changelog entry.
>
> Also, users may need to figure out that ClojureScript src blocks
> need a proper environment to execute src blocks. I.e. we should
> recommend users to have their .org file within a ClojureScript
> project -- I added something along these lines in the ORG-NEWS
> entry.
>
> If you want to contribute further, you'd need to sign the FSF
> papers: https://orgmode.org/request-assign-future.txt
>
> Thanks!
- --
[ stardiviner ]
I try to make every word tell the meaning what I want to express.
Blog: https://stardiviner.github.io/
IRC(freenode): stardiviner, Matrix: stardiviner
GPG: F09F650D7D674819892591401B5DF1C95AE89AC3
-----BEGIN PGP SIGNATURE-----
iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5GLv4UHG51bWJjaGls
ZEBnbWFpbC5jb20ACgkQG13xyVromsMkfAf/fFCfp91u8ZtK9VyVjlpf+tZ0wZzU
7d0OPcbnEtUZH/FkGyG2eFgXN/WBnf8O31ESj5EyXtnDGNZSa3Ia/cgmC7ZtCJRp
9w7YbwPnfM9EBq5qK7R+9i6fCEcua5i4Oszx4x1erWuksfGogCdKN6gwZJMYlH5y
lqdGQ0LCZMnTxDHn4mi8JuM2K0kaaIK4oJMJmCLu8+/X6lvTbLjGsTl08dew0Pbx
jMEkV/3FvtFNeS7MZIIrZedPgAhiS3o6IUj+hmngVpKdcabOZmBkV5IFgvMB77Us
SuSKs3Y9Y4hlWZyBMV2Twc4lKicnO31vGJm9MmFn4LCjI3Fd5O6LFEnL0A==
=GDMy
-----END PGP SIGNATURE-----
- Re: [O] [PATCH 2/4] ob-clojure.el: Add ClojureScript interface, stardiviner, 2020/02/12
- Re: [PATCH 2/4] ob-clojure.el: Add ClojureScript interface, Bastien, 2020/02/12
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface,
stardiviner <=
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, Bastien, 2020/02/14
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, stardiviner, 2020/02/14
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, Bastien, 2020/02/14
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, Tim Cross, 2020/02/14
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, Bastien, 2020/02/16
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, Tim Cross, 2020/02/16
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, Bastien, 2020/02/16
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, stardiviner, 2020/02/18
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, Bastien, 2020/02/18
- Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface, stardiviner, 2020/02/19