[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header a
|
From: |
Nicolas Goaziou |
|
Subject: |
Re: [O] [PATCH 2/2] test-ob-emacs-lisp: Test :lexical src block header argument |
|
Date: |
Thu, 14 Mar 2019 23:38:32 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Sebastian Miele <address@hidden> writes:
> After some initial tooth-grinding,
My intent is not to be negative. I do understand that writing tests
takes time.
However, from experience, having to fix a regression when your only
indication comes from a test you do not fully understand is a pain. To
see what I mean, have a look at tests in
"test-ob-header-arg-defaults.el" and imagine one of them fails…
> I did rewrite them, and actually like
> the result more than the previous version. Thank you for the suggestion!
>
> Here is the updated patch:
Thank you. I applied it.