[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [o] org-capture regression?
From: |
Nicolas Goaziou |
Subject: |
Re: [O] [o] org-capture regression? |
Date: |
Thu, 20 Sep 2018 14:53:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Hello,
Thomas Holst <address@hidden> writes:
> a view weeks ago a wrote a post about problems I have with one of my
> captue templates. (see:
> http://lists.gnu.org/archive/html/emacs-orgmode/2018-08/msg00161.html)
I thought I had answered it.
> Since a few weeks this is not working anymore. I have a capture template
> unsing this feature (which I use rarely but still).
>
> So here is I patch I came up with to re-enable theese features:
Thank you. However, I have two issues with it.
The first one is that I don't like `eval'. See, for example, this
excerpt from the Elisp manual:
On rare occasions, you may need to write code that evaluates a form
that is computed at run time, such as after reading a form from text
being edited or getting one from a property list. On these
occasions, use the ‘eval’ function. Often ‘eval’ is not needed and
something else should be used instead. For example, to get the value
of a variable, while ‘eval’ works, ‘symbol-value’ is preferable; or
rather than store expressions in a property list that then need to
go through ‘eval’, it is better to store functions instead that are
then passed to ‘funcall’.
So, I'd rather use `symbol-value' and `funcall' and forbid arbitrary
Sexps.
Also, this introduces a discrepancy between :table-line-pos and other
parameters, which do not allow variables nor functions. This is another
issue.
IOW, it may need be to be implemented at a lower level, with proper
tooling.
WDYT?
> This works for me. I can use my capture template again. In the
>meantime I signed FSF papers so TINYCHANGE is not required anymore.
Great!
Regards,
--
Nicolas Goaziou