Re: [O] [PATCH 2/2] org-colview.el: Add property :exclude-tags to column view

[Nicolas Goaziou]

Hello,

Benjamin Motz <address@hidden> writes:

> This addition allows to specify a list of tags to exclude from column
> view tables.
>
> From 4ac32c4b24f33b841ad73c4b10158ec7a18087a9 Mon Sep 17 00:00:00 2001
> From: Benjamin Motz <address@hidden>
> Date: Wed, 4 Jul 2018 14:27:24 +0200
> Subject: [PATCH 2/2] org-colview.el: Add property :exclude-tags to column view
>  table
>
> This addition allows to specify a list of tags to exclude from column
> view tables.
>
> TINYCHANGE

It looks good. This need to be documented in the manual, though. Would you
mind adding this to your patch. 

Also, a test would be nice in "test-org-colview.el", more accurately in
`test-org-colview/dblock'. Could you add one?

> -(defun org-columns--capture-view (maxlevel match skip-empty format local)
> +(defun org-columns--capture-view (maxlevel match skip-empty exclude-tags 
> format local)
>    "Get the column view of the current buffer.

You need to describe the new argument in the docstring.

Thank you.

Regards,

-- 
Nicolas Goaziou