emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ob-clojure.el and ob-clojure-literate.el support new hea


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] ob-clojure.el and ob-clojure-literate.el support new header argument :ns
Date: Sat, 14 Apr 2018 18:31:44 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux)

Hello,

stardiviner <address@hidden> writes:

> After about 5 times test, And about 4 times review. I decide to PR.

Thank you.

I applied the patches with some substantial changes to commit messages
(often incomplete), removed "subr-x.el" calls (`thread-last' is just
confusing) and fixed compilation warnings.

Please double-check as I might have fumbled in the process.

I didn't change "ob-clojure-literate.el" but there are dangling parens
and whitespace issues to fix. Also, I don't see the need for `dash'
library, but since it's a contrib/ package, I won't insist of it.


Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]