Re: [O] [PATCH] add :session support for ob-js.el

[stardiviner]

I attached my new generated patches.


On 03/17/2018 07:14 PM, Nicolas Goaziou wrote:
> Some comments follow.
> > +              (result (if (not (string= (cdr (assq :session params)) "none"))
> You can integrate the test above in the `cond':
>
> (cond
>   ((string= "none" (cdr (assq :session params))) nil)
>   ((string= "*JS REPL*" session) ...)
>   ...)
This is modified in new patch.
> > +             (sit-for .5) (goto-char (point-max))
> (sit-for .5)
> (goto-char (point-max))
This is in original code, might because ob-js initialize REPL backend 
need some time so original author added `site-for`. After test, this 
seems does not matter. So remote the sit-for now.
> > +             (mapc (lambda (var)
> > +                           (insert var) (comint-send-input nil t)
> > +                           (org-babel-comint-wait-for-output session)
> > +                           (sit-for .1) (goto-char (point-max))) var-lines)))
> >       session))
>    (dolist (var ...)
>     ...)
modified in new patch.

I don't know how to apply master branch new update on my local 
`ob-js-session` branch so to get ob-js related commits on top to 
generate new patches. (Do you have any idea on this?) The new patches 
are behind latest `master` branch. But should be compatible still. If 
generating patches based on latest `master` branch commit is must, I can 
do that.

0001-ob-js.el-support-session-for-skewer-mode-REPL.patch
Description: Text Data

0002-ob-js.el-support-session-for-Indium-Node-REPL.patch
Description: Text Data

0003-ob-js.el-support-session-for-js-comint-REPL.patch
Description: Text Data

0004-ob-js.el-org-babel-prep-session-js-replace-mapc-with.patch
Description: Text Data