emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] [BUG] org-sort-entries errors out when headline is empty


From: Sebastian Reuße
Subject: [O] [BUG] org-sort-entries errors out when headline is empty
Date: Tue, 13 Mar 2018 17:51:43 +0100

So, I’ve noticed that when sorting a subtree (alphabetically or numerically),
‘org-sort-entries’ will raise an error arising from the call to
‘org-sort-remove-invisible’ (lines 8761 and 8766 in bc7b24d0d).

I’m following up with a test. The error is triggered by the capture group in
‘org-complex-heading-regexp’ returning nil, which is then passed on to
‘org-sort-remove-invisible’, which expects a string and chokes on the nil.

As for a fix, the quick fix would be guarding against this case in
‘org-sort-remove-invisible’, but that seemed a bit meh since sanitation should
probably be handled higher up.

An alternative is to guard inside ‘org-sort-entries’. I’m following up with an
implementation of this.

I was also wondering if it might make sense to tweak
‘org-complex-heading-regexp’ so that the respective capture group captures an
empty string. This could be achieved by making the title group greedy again
(reverting 9d334897e). Whether we want this probably depends on the motivation
for 9d334897e. However, doing so would be more consistent with the org-elements
API, which does assign a tag list to the title property when the heading is
otherwise empty.

Any thoughts?

Kind regards,
SR

-- 
Insane cobra split the wood
Trader of the lowland breed
Call a jittney, drive away
In the slipstream we will stay




reply via email to

[Prev in Thread] Current Thread [Next in Thread]