emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] lisp/org.el: make org-open-at-point handle parens in enc


From: Marc Ihm
Subject: Re: [O] [PATCH] lisp/org.el: make org-open-at-point handle parens in encoded urls correctly
Date: Fri, 11 Aug 2017 20:24:11 +0200
User-agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2

Am 11.08.2017 um 18:10 schrieb Nicolas Goaziou:
Hello,

Marc Ihm <address@hidden> writes:

the attached patch changes org-open-at-point in org.el:

Currently, when opening an url the function org-open-at-point uses the
variable path, which is the result of applying org-link-unescape on
the original url. Thus, all special chars like '() "' etc. which were
originally encoded like %20%28 etc. are reverted to their clear text
form. This worked for me in most cases, but gives me errors when my
url contains encoded chars like '()', i.e. %28%29.

The submitted patch fixes this by simply using the original url with
all special chars still encoded.

Please consider applying it, if fit.

Thank you.

The problem here is that Org could introduce additional percent-encoding
upon creating a link. This additional layer needs to be removed before
opening the link.

I think there's a deeper issue to solve here. Your patch is likely to
move the problem elsewhere.

Regards,


Hi Nicolas,

well the code which I tried to patch is indeed convoluted and changing things might indeed have side effects; so I keep this fix for myself and see how it behaves on the long run :-)

Thanx for explaining !

regards
Marc




reply via email to

[Prev in Thread] Current Thread [Next in Thread]