emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] protocol: allow users to disable warning about old style


From: Alex Branham
Subject: Re: [O] [PATCH] protocol: allow users to disable warning about old style links
Date: Fri, 16 Jun 2017 13:31:31 +0200
User-agent: mu4e 0.9.18; emacs 25.2.1

Hi, thanks for the reply.

On Fri 16 Jun 2017 at 06:13, Nicolas Goaziou <address@hidden> wrote:

> Hello,
>
> Alex Branham <address@hidden> writes:
>
>> This patch allows org mode users to disable the warning issued about
>>old org protocol style links. This is important because sometimes (e.g.
>>browser extensions), we don’t have easy control over the format
>>specified.
>
> Thank you.
>
> Wouldn't it be better to report it upstream as a bug? I don't think
> there are many Org protocols applications out there and the conversion
> to the new syntax is easy.

I did report it upstream as a bug. The maintainer is (understandably, I think) 
hesitant to change since 1) old style links continue to be supported and 2) 
there’s no way for a browser extension to detect the version of org-mode to 
install. Since new style links aren’t supported in older org versions (like 
what comes shipped with Emacs), that could create issues.

>
>> Issuing the warning is annoying because it pops up in a new window.
>
> I think this variable should go in "org-compat.el", so that we can
> remove it when we drop old syntax. It also need
> proper :version, :package-version and :safe keywords.
>
> Another option is to make it a simple `defvar' and have the warning
> message suggesting to set it.

I changed it to a defvar and modified the warning. That seems simpler to me.

I wasn’t sure if defvars should go into org-compat.el (that file says it’s for 
compatibility issues with older Emacs versions?) or stay where it is. I’ve left 
it where it is for now but I can move it to org-compat.el if you want me to.

New patch attached and pasted below.

>
> WDYT?
>
>> From 8bfc951308324de8e455128950193c046691f1f8 Mon Sep 17 00:00:00 2001
>> From: Alex Branham <address@hidden>
>> Date: Wed, 14 Jun 2017 14:06:18 +0200
>> Subject: [PATCH] protocol: allow user to disable warning about old style 
>> links
>>
>> ---
>>  lisp/org-protocol.el | 11 +++++++++--
>>  1 file changed, 9 insertions(+), 2 deletions(-)
>>
>> diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
>> index 825435674..2eb1094e9 100644
>> --- a/lisp/org-protocol.el
>> +++ b/lisp/org-protocol.el
>> @@ -271,6 +271,12 @@ This should be a single regexp string."
>>    :package-version '(Org . "8.0")
>>    :type 'string)
>>
>> +(defcustom org-protocol-warn-about-old-links t
>> +  "If non-nil (the default), issue a warning when org protocol
>> +receives old style links."
>
>   When non-nil, warn when Org protocol receives old style link.
>
>
> Regards,

>From 5d04e3a9404b2109751da6e43fba24a7cace00a8 Mon Sep 17 00:00:00 2001
From: Alex Branham <address@hidden>
Date: Fri, 16 Jun 2017 13:24:44 +0200
Subject: [PATCH] org-protocol: add option to surpress warning about old links

---
 lisp/org-protocol.el | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/lisp/org-protocol.el b/lisp/org-protocol.el
index 825435674..531345b58 100644
--- a/lisp/org-protocol.el
+++ b/lisp/org-protocol.el
@@ -271,6 +271,10 @@ This should be a single regexp string."
   :package-version '(Org . "8.0")
   :type 'string)

+(defvar org-protocol-warn-about-old-links t
+  "If non-nil (the default), issue a warning when org protocol
+receives old style links.")
+
 ;;; Helper functions:

 (defun org-protocol-sanitize-uri (uri)
@@ -618,8 +622,9 @@ CLIENT is ignored."
                             (if new-style
                                 (funcall func (org-protocol-parse-parameters
                                                result new-style))
-                              (warn "Please update your Org Protocol handler \
-to deal with new-style links.")
+                              (when org-protocol-warn-about-old-links
+                                (warn "Please update your Org Protocol handler 
\
+to deal with new-style links.\n                 You may set 
`org-protocol-warn-about-old-links' to nil to surpress this message."))
                               (funcall func result))))
                    ;; Greedy protocol handlers are responsible for
                    ;; parsing their own filenames.
--
2.13.1



--
J. Alexander Branham
PhD Candidate
Department of Government
University of Texas at Austin
https://www.jabranham.com

Attachment: 0002-org-protocol-add-option-to-surpress-warning-about-ol.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]