Re: [O] [PATCH] Add a custom list in org-mac-link.el

[Nicolas Goaziou]

Takaaki Ishikawa <address@hidden> writes:

> Thank you for your kind feedback. Please find my comments below.

Thank you for the quick answer.

> Updated docstring is
>
>   "Alist of descriptors. Each descriptor consists of four elements to build
> the link grabber menu in the minibuffer. A single character shall be used
> for the first element to select an application, and the pair with the second
> element represents the name of the application. The third element is a
> function to insert information grabbed from selected application. And the
> last
> element is a flag to indicate whether the descriptor appears in the link
> grabber menu."

Nice. Note that we can make it more explicit, e.g.,

  A descriptor follows the pattern:

    (KEY NAME FUN FLAG)

  where KEY is ...

The first line needs to end with the first sentence, i.e.,
"descriptors". Also, you need two spaces after each sentence.

>> +  :tag "A list of descriptors"
>> > +  :group 'org-mac-link'
>> > +  :type 'symbol)
>>
>> The :type value is wrong. You need a composite type here.
>>
>
> What do you feel about the following composite type.
>
> :type '(alist :value-type (string string function boolean)

OK. You could introduce :tag to make it easier,e.g.

  (string :tag "Key: ")


Regards,