emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH v2] org-sort: Read compare-func in interactive calls


From: Nicolas Goaziou
Subject: Re: [O] [PATCH v2] org-sort: Read compare-func in interactive calls
Date: Sun, 14 May 2017 18:51:03 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

Kyle Meyer <address@hidden> writes:

> Won't using a numeric prefix argument change the behavior for both
> interactive and Lisp calls?
>
> As examples,
>
>   * M-1 M-x org-sort-list is currently interpreted as a non-nil value
>     for WITH-CASE.  Instead, it would be indistinguishable from M-x
>     org-sort-list.
>
>   * A Lisp caller can currently set WITH-CASE to any non-nil value.
>     Using (interactive "p") for WITH-CASE, how do we distinguish a
>     numeric argument passed for WITH-CASE from an interactive call?

OK. It seems I was pretty much confused.

> Using an additional argument whose only purpose is to serve as a
> interactive flag, which is what called-interactively-p's docstring
> suggests, avoids these issues.

I'd rather avoid this. What about using

  (not (or executing-kbd-macro noninteractive))

then, and not touch to signature?

Regards,



reply via email to

[Prev in Thread] Current Thread [Next in Thread]