Re: [O] Bug: org-agenda-columns failing when Diary entries are included [9.0.5 (9.0.5-dist @ /home/ohanluaine/eibhear_org/lisp/org-9/lisp/)]

[Nicolas Goaziou]

Hello,

"Éibhear" <address@hidden> writes:

> I believe there's a bug in org-mode 9.0 when calling
> org-agenda-columns in an agenda view that includes items from the
> emacs diary file.
>
> To reproduce
> ============
> 1. Setup:
>    The following shell commands should build the test case.
>
> # a) Create a location for this test case:
> mkdir -vp ~/tmp/columns-bug
>
> # b) Create a simple org-mode file:
> cat << EOF > ~/tmp/columns-bug/columns-bug.org
> * TODOs
> ** TODO Eat your chocolate egg
>    SCHEDULED: <2017-04-16 Sun 11:30>
> ** TODO Wish Michael a Happy Birthday
>    SCHEDULED: <2017-03-17 Fri 10:00>
> EOF
>
> # c) Create a simple diary file:
> cat << EOF > ~/tmp/columns-bug/columns-bug.diary
> 17 March 2017 12:01 Afternoon is well and truly started
> EOF
>
> # d) Create a (not so) simple init file (this assumes that org
> #    mode 9.0 is somewhere on the load-path):
> cat << EOF > ~/tmp/columns-bug/columns-bug.init
>
> (require 'appt)
>
> (custom-set-variables
>  ;; custom-set-variables was added by Custom.
>  ;; If you edit it by hand, you could mess it up, so be careful.
>  ;; Your init file should contain only one such instance.
>  ;; If there is more than one, they won't work right.
>  '(appt-disp-window-function 'appt-disp-window)
>  '(appt-display-duration 60)
>  '(appt-display-format (quote window))
>  '(appt-display-interval 5)
>  '(appt-message-warning-time 15)
>  '(calendar-date-style (quote european))
>  '(calendar-latitude 52.36)
>  '(calendar-location-name "Dublin, Ireland")
>  '(calendar-longitude -6.19)
>  '(calendar-mark-diary-entries-flag t)
>  '(calendar-time-display-form
>    (quote (24-hours ":" minutes (if time-zone " (")
>                     time-zone (if time-zone ")")))
>    )
>  '(calendar-view-diary-initially-flag t)
>  '(diary-file "~/tmp/columns-bug/columns-bug.diary")
>  '(diary-hook (quote (appt-make-list)))
>  '(diary-list-entries-hook (quote (diary-include-other-diary-files)))
>  '(diary-list-include-blanks t)
>  '(diary-number-of-entries 7)
>  '(display-time-24hr-format t)
>  '(org-agenda-files (quote ("~/tmp/columns-bug/columns-bug.org")))
>  '(org-agenda-include-diary t)
>  '(org-finalize-agenda-hook (quote (org-agenda-to-appt)))
>  '(org-sort-agenda-notime-is-late nil)
>  )
>
> (org-agenda-list nil "2017-03-17" 'day)
> EOF
>
> # e) Launch emacs:
> emacs -Q -l ~/tmp/columns-bug/columns-bug.init
>
>    This will start emacs, calling columns-bug.init instead of
>    .emacs, and will immediately show the org-agenda-list screen for
>    the 17th March, 2017. There you'll see three entries:
>    - St. Patrick's Day from "Diary". This is a calculated entry
>      because diary-show-holidays-flag is t.
>    - The "Wish Michael a Happy Birthday" TODO from the org-mode file
>      above.
>    - The "Afternoon is well and truly started" diary item from the
>      diary file above.
>
> 2. Call org-agenda-columns interactively.
>
>
> Expected Result
> ===============
> The columns overlay for the agenda should be presented.
>
>
> Actual Result
> =============
> The building of the columns view fails with the following report in
> the minibuffer:
>
> Wrong type argument: number-or-marker-p, nil

Fixed. Thank you.

Regards,

-- 
Nicolas Goaziou