Re: [O] Fontification error

[Noam Postavsky]

On Sun, Mar 19, 2017 at 1:05 PM, Kyle Meyer <address@hidden> wrote:
>>
>>     * lisp/org-src.el (org-src-font-lock-fontify-block): Let-bind
>>     `inhibit-modification-hooks' to nil, since this function can be called
>>     from jit-lock-function which binds that variable to t (Bug#25132).
>>
>>     Call modification hooks in org-src fontify buffers
>>     ae8264c5cccf19d5b25a340a605bf2f07de1577e
>>     Noam Postavsky
>>     Sun Jan 29 11:01:32 2017 -0500
>>
>> At the moment, the minimum ECM I know of is to install spacemacs and
>> open an org file containing:
>
> [+cc Noam because I'm not sure if he follows this list.]

[Thanks, I don't follow this list indeed]

>
> I backported this commit to the Org repo, but I don't have any good
> guesses at what's leading to the error below.

I think the problem is that the let-binding's scope is too big, it's
applying to a text property change on the original org buffer, which
seems to cause problems with one of its modifcation hooks due to
narrowing. Actually, I initially posted the patch with a smaller
binding, but then enlarged it before I pushed it; I don't remember
why...

Could someone who can reproduce this problem try shrinking the scope
of (let ((inhibit-modification-hooks nil))...) to stop after the
(insert " ") as in [1], and see if that fixes it?

[1]: 
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=25132;att=3;filename=v1-0001-Call-modification-hooks-in-org-src-fontify-buffer.patch;msg=22