emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Add support for ordered list to ox-confluence.el


From: Lungang Fang
Subject: Re: [O] [PATCH] Add support for ordered list to ox-confluence.el
Date: Fri, 9 Dec 2016 19:34:32 +1100

Great! Then, what about using my patch ? It would be my first patch adopted by any open source project, a real milestone  :)

On Friday, December 9, 2016, Charles Durst <address@hidden> wrote:
I have tried the results of both versions and loaded them into the
Confluence Wiki, and Lungang is correct, from what I can tell, they
both will work.

So I don't really care which one you choose either.  I just needed the
functionality.
--
Charles Durst
address@hidden

On Thu, Dec 8, 2016 at 9:32 PM, Lungang Fang <address@hidden> wrote:
> Hi Charles and Nicholas,
>
> My code also supports nested mixed lists but is simpler. I mean, my code
> will convert the list given by Charles to
>
> # Here
> -- is
> -- an
> # example
> -- of
> -- a
> # mixed
> # list
>
> Although this format is not mentioned in confluence wiki, it is supported by
> conflucence according to my test (in Jira).
>
> So, in my opinion, it is a matter of personal preference: more complicated
> code complies with documented interface, or simpler code that exploits
> undocumented feature.
>
> I prefer my code. But you guys feel free to make decision. I am OK with
> whatever you choose.
>
> Cheers,
> Lungang
>
> On Fri, Dec 9, 2016 at 10:37 AM, Charles Durst <address@hidden>
> wrote:
>>
>> They do conflict.  My version is slightly more complicated since it
>> also supports nested mixed lists.
>>
>> For example:
>>
>> 1. Here
>>    * is
>>    * an
>> 2. example
>>    * of
>>    * a
>> 3. mixed
>> 4. list
>>
>> Which translates to:
>>
>> # Here
>> #- is
>> #- an
>> # example
>> #- of
>> #- a
>> # mixed
>> # list
>>
>> Which is effectively the same as the example in the Confluence
>> documentation:
>>
>> https://confluence.atlassian.com/confcloud/confluence-wiki-markup-724765099.html#ConfluenceWikiMarkup-Mixedlists
>>
>> --
>> Charles Durst
>> address@hidden
>>
>>
>> On Thu, Dec 8, 2016 at 5:49 PM, Nicolas Goaziou <address@hidden>
>> wrote:
>> > Hello,
>> >
>> > Lungang Fang <address@hidden> writes:
>> >
>> >> Attached is a patch for contrib/lisp/ox-confluence.el generated
>> >> following
>> >> instructions on http://orgmode.org/worg/org-contribute.html#patches .
>> >> It
>> >> adds support for ordered list.
>> >
>> > Thank you.
>> >
>> > However, this somewhat conflicts with a patch recently sent on the ML,
>> > but not yet applied, by Charles Durst (Cc'ed).
>> >
>> > Could one double-check if one doesn't supersede the other, or if they
>> > could be merged (although I suspect the former) and report back so
>> > I know what patch to apply?
>> >
>> > Regards,
>> >
>> > --
>> > Nicolas Goaziou
>
>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]