emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] Problem with eldoc and Python


From: Fabrice Popineau
Subject: Re: [O] Problem with eldoc and Python
Date: Thu, 7 Jul 2016 11:33:51 +0200

Here a 2 very small patches for contrib/lisp/org-eldoc.el

Regards,

Fabrice



2016-07-06 23:27 GMT+02:00 Nicolas Goaziou <address@hidden>:
Fabrice Popineau <address@hidden> writes:

> The problem is that the byte code comes from Python mode.
> I solved the problem with this:
>
> $ diff -uw contrib/lisp/org-eldoc.el contrib/lisp/org-eldoc.el
> --- contrib/lisp/org-eldoc.el   2016-02-29 11:13:22.330099500 +0100
> +++ contrib/lisp/org-eldoc.el   2016-07-04 07:11:10.466144400 +0200
> @@ -155,7 +155,8 @@
>               (string= lang "golang")) (when (require 'go-eldoc nil t)
>
>  (go-eldoc--documentation-function)))
>             (t (let ((doc-fun
> (org-eldoc-get-mode-local-documentation-function lang)))
> -                (when (fboundp doc-fun) (funcall doc-fun))))))))
> +                (when (or (and (symbolp doc-fun) (fboundp doc-fun))
> +                         (functionp doc-fun)) (funcall doc-fun))))))))

Wouldn't

  (when (functionp doc-fun) (funcall doc-fun))

be enough?

Also, would you provide a patch for this?

Thank you.

Regards,

Attachment: 0001-The-doc-fun-object-may-be-a-function-object-and-not-.patch
Description: Binary data

Attachment: 0001-When-inserting-a-new-src-block-the-language-may-not-.patch
Description: Binary data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]