emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] [PATCH] Fix the single quote printed in the message printed by org-t


From: Kaushal Modi
Subject: [O] [PATCH] Fix the single quote printed in the message printed by org-table-edit-formulas
Date: Wed, 9 Mar 2016 11:18:17 -0500

Hi all,

Can someone please review and commit this patch. 

It basically prints the "C-c '" binding correctly in the echo area, using straight quote instead of curly quote (matters in emacs 25.x). The details are in the commit log below.


From f4411b59d8dc4e5b3df79ccbcd87f6bfe5160776 Mon Sep 17 00:00:00 2001
From: Kaushal Modi <address@hidden>
Date: Wed, 9 Mar 2016 01:18:58 -0500
Subject: [PATCH] Fix the single quote printed in the message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Fix the quote style when in the "C-c '" key-binding that is printed in the echo via the substitute-command-keys function. In emacs 25.x, a straight quote is rendered as a right-curly quote by default.

So below will render that single quote as curly.

(message "C-c '")

The fix is to print that quote verbatim using the "%s" modifier:

(message "%s" "C-c '")

Below is how this commit changes the message echoed in the org-table-edit-formulas function.

Earlier:
  Edit formulas, finish with ‘C-c C-c’ or ‘C-c ’’.  See menu for more commands.

After fix:
  Edit formulas, finish with ‘C-c C-c’ or ‘C-c '’.  See menu for more commands.

Note the difference in the single quote style in "C-c '".
---
 lisp/org-table.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 488c912..0a25772 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -3591,7 +3591,7 @@ Parameters get priority."
       (when (eq org-table-use-standard-references t)
  (org-table-fedit-toggle-ref-type))
       (org-goto-line startline)
-      (message
+      (message "%s"
         (substitute-command-keys "\\<org-mode-map>\
 Edit formulas, finish with `\\[org-ctrl-c-ctrl-c]' or `\\[org-edit-special]'.  \
 See menu for more commands.")))))



--
Kaushal Modi

reply via email to

[Prev in Thread] Current Thread [Next in Thread]