emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] [PATCH] org-table.el: Fix regexp used for splitting data rows when c


From: Piotr Gajewski
Subject: [O] [PATCH] org-table.el: Fix regexp used for splitting data rows when computing a formula
Date: Wed, 2 Dec 2015 12:27:34 +0100

* lisp/org-table.el (org-table-eval-formula): Fix regexp
  used for splitting data rows.

* Explanation /root node/

*** Example 1: Spaces ' ' in front of a data row (OK)

    |---+-----+------+---+----+-----|
    | ! | sum |      | a |  b |   c |
    |---+-----+------+---+----+-----|
    | # | 111 | 1000 | 1 | 10 | 100 |
    |---+-----+------+---+----+-----|
    #+TBLFM: $2=$a+$b+$c

    List of values after splitting data row:
    ("#" "" "1000" "1" "10" "100")

    Formula is computed correctly.

*** Example 2: Tabulators '\t' in front of a data row (ERROR)

    |---+------+------+---+----+-----|
    | ! |  sum |      | a |  b |   c |
    |---+------+------+---+----+-----|
    | # | 1011 | 1000 | 1 | 10 | 100 |
    |---+------+------+---+----+-----|
    #+TBLFM: $2=$a+$b+$c

    List of values after splitting data row:
    ("\t" "#" "" "1000" "1" "10" "100")

    There is an extra field containing '\t' character(s).
    All /genuine/ values are shifted to the right.
    Consequently, references to fields lookup the wrong values.

TINYCHANGE
---
 lisp/org-table.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/org-table.el b/lisp/org-table.el
index 17424be..9ed8b6e 100644
--- a/lisp/org-table.el
+++ b/lisp/org-table.el
@@ -2723,7 +2723,7 @@ not overwrite the stored one."
       (while (> ndown 0)
     (setq fields (org-split-string
               (buffer-substring-no-properties (point-at-bol) (point-at-eol))
-              " *| *"))
+              "[ \t]*|[ \t]*"))
     ;; replace fields with duration values if relevant
     (if duration
         (setq fields
-- 
1.9.5.msysgit.0

                                          


reply via email to

[Prev in Thread] Current Thread [Next in Thread]