emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH 2/8] ox-taskjuggler.el: factor 'org-export-map-special-no


From: Rasmus
Subject: Re: [O] [PATCH 2/8] ox-taskjuggler.el: factor 'org-export-map-special-nodes'
Date: Thu, 12 Nov 2015 17:42:51 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Kosyrev Serge <address@hidden> writes:

> * ox-taskjuggler.el (org-taskjuggler-map-special-nodes):
> new function to capture mapping over tagged special nodes.
> (org-taskjuggler-project-plan): factor to use the new function.

>  ;;; Translator Functions
> +(defun org-taskjuggler-map-special-nodes (tag tree f)
> +  (org-element-map tree 'headline
> +    (lambda (hl)
> +      (and (member tag (org-export-get-tags hl info))

Should it look care about case?  Otherwise member-ignore-case.

> +          (funcall f hl)))
> +    info nil 'headline))



>  (defun org-taskjuggler-project-plan (contents info)
>    "Build TaskJuggler project plan.
> @@ -647,13 +653,10 @@ Return complete project plan as a string in TaskJuggler 
> syntax."
>              ;; `org-taskjuggler-resource-tag'.  Only gather top level
>              ;; resources.
>              (apply 'append
> -                   (org-element-map tree 'headline
> -                     (lambda (hl)
> -                       (and (member org-taskjuggler-resource-tag
> -                                    (org-export-get-tags hl info))
> -                            (org-element-map (org-element-contents hl) 
> 'headline
> -                              'identity info nil 'headline)))
> -                     info nil 'headline))))
> +                  (org-taskjuggler-map-special-nodes
> +                   org-taskjuggler-resource-tag tree
> +                   (lambda (hl) (org-element-map (org-element-contents hl) 
> 'headline
> +                                  'identity info nil 'headline))))))

Do you need org-taskjuggler-map-special-nodes elsewhere (sorry, I can’t
keep all of your patches in mind at the same time)?

Rasmus

-- 
ツ




reply via email to

[Prev in Thread] Current Thread [Next in Thread]