Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store

emacs-orgmode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store

From:	Jan Malakhovski
Subject:	Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props
Date:	Wed, 04 Nov 2015 11:45:44 +0000
User-agent:	Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.2 (x86_64-unknown-linux-gnu)

Aaron Ecay <address@hidden> writes:

> Can you introduce a let binding so that (date-to-time x) is only called
> once?

Ok.

> Also, what is ignore-errors protecting? The call to date-to-time, or
> format-time-string? I think the scope of ignore-errors should be as
> narrow as it can be.

I have no idea. I moved these lines from org-gnus, equivalent lines in
org-*other-mail-reader*s don't use ignore-errors at all. I don't use
gnus so went for the safest change.

[Prev in Thread]

Current Thread

[Next in Thread]

[O] [PATCH 3/9] org-clock: fix `org-clock-time%', (continued)
- [O] [PATCH 3/9] org-clock: fix `org-clock-time%', Jan Malakhovski, 2015/11/03
  - Re: [O] [PATCH 3/9] org-clock: fix `org-clock-time%', Aaron Ecay, 2015/11/04
    - Re: [O] [PATCH 3/9] org-clock: fix `org-clock-time%', Jan Malakhovski, 2015/11/04
- [O] [PATCH 2/9] org-colview: add a FIXME, Jan Malakhovski, 2015/11/03
- [O] [PATCH 4/9] org: move `org-duration-string-to-minutes' to a better place, Jan Malakhovski, 2015/11/03
- [O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere, Jan Malakhovski, 2015/11/03
  - Re: [O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere, Aaron Ecay, 2015/11/04
    - Re: [O] [PATCH 5/9] rename `org-duration-string-to-minutes' to `org-clocksum-string-to-minutes' everywhere, Jan Malakhovski, 2015/11/04
- [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props, Jan Malakhovski, 2015/11/03
  - Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props, Aaron Ecay, 2015/11/04
    - Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props, Jan Malakhovski <=
    - Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props, Aaron Ecay, 2015/11/04
    - Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props, Jan Malakhovski, 2015/11/04
- [O] [PATCH 7/9] org-notmuch: add date support to org-notmuch-store-link, Jan Malakhovski, 2015/11/03
- [O] [PATCH 8/9] ob-calc: add more API, documentation and examples so that it can be used in tables, Jan Malakhovski, 2015/11/03
- [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Jan Malakhovski, 2015/11/03
  - Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Aaron Ecay, 2015/11/04
    - Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Jan Malakhovski, 2015/11/04
    - Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Aaron Ecay, 2015/11/04
    - Re: [O] [PATCH 9/9] ob-calc: don't leave garbage on the stack, Jan Malakhovski, 2015/11/04
- Re: [O] [PATCH v2 0/9] mail, clock and calc changes, Aaron Ecay, 2015/11/04

Prev by Date: Re: [O] Resolving links breaks workflow using org-narrow-to-subtree
Next by Date: Re: [O] [PATCH 3/9] org-clock: fix `org-clock-time%'
Previous by thread: Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props
Next by thread: Re: [O] [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props
Index(es):
- Date
- Thread