[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed.
From: |
Matt Lundin |
Subject: |
Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed. |
Date: |
Fri, 23 Oct 2015 14:59:00 -0500 |
User-agent: |
Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) |
Rasmus <address@hidden> writes:
> Hi Puneeth,
>
> Thanks for your patch.
>
> Puneeth Chaganti <address@hidden> writes:
>
>> I've attached a one-line patch to fix `org-id-goto' if the target
>> buffer is narrowed. Let me know if this fix sounds reasonable or if
>> you have other suggestions!
>
> It's not obvious that org should change a—potentially—carefully selected
> narrowed region.
Org mode already does this aggressively and often. For instance, it
irrevocably widens all buffers associated with org-agenda-files when
generating the agenda. (To replicate, try narrowing to a headline in a
buffer and then calling the agenda.) The same is true of follow mode; it
widens a buffer once one moves to a line in the agenda corresponding to
that buffer. In other words, org currently does not go out of its way to
protect user's narrowed regions.
+1 on my part for widening a buffer if it contains a relevant id target.
If I click org-id-goto and the target is in my buffer, I want it to
widen that buffer.
Matt
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., (continued)
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., John Kitchin, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Rasmus, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/24
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Nicolas Goaziou, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Nicolas Goaziou, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Rasmus, 2015/10/25
- Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed., Puneeth Chaganti, 2015/10/26
Re: [O] [PATCH] org-id-goto doesn't work if buffer is narrowed.,
Matt Lundin <=