[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[O] Fix for clocking in when org-clock-into-drawer is not a string
From: |
Tom Hinton |
Subject: |
[O] Fix for clocking in when org-clock-into-drawer is not a string |
Date: |
Thu, 13 Aug 2015 15:32:51 +0100 |
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) |
Hello,
I have encountered a fault in recent versions of org when clocking into a task
with a dangling clock when
org-clock-into-drawer is an integer rather than a string. It appears the error
was a presumption that
org-clock-into-drawer would be a string for the construction of a regex.
Attached is a trivial single line patch
which seems to fix this for me. make test reports no additional test failures
with the patch applied.
All the best,
Tom Hinton
>From 498b0ae295453e1ce5ef42d54cb8dfb9f930809e Mon Sep 17 00:00:00 2001
From: Tom Hinton <address@hidden>
Date: Wed, 12 Aug 2015 12:46:47 +0100
Subject: [PATCH] Fix clock in when org-clock-into-drawer is integer
* org-clock.el (org-clock-jump-to-current-clock):
fixed a bug wherein org-clock-jump-to-current-clock did not work if
org-clock-into-drawer
was not either a string or nil.
This is a TINYCHANGE, although I am happy to assign copyright to the FSF.
---
lisp/org-clock.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index e44da73..6de093f 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -950,7 +950,7 @@ If necessary, clock-out of the currently active clock."
(when drawer
(org-with-wide-buffer
(let ((drawer-re (format "^[ \t]*:%s:[ \t]*$"
- (regexp-quote (or drawer "LOGBOOK"))))
+ (regexp-quote (if (stringp drawer) drawer
"LOGBOOK"))))
(beg (save-excursion (outline-back-to-heading t) (point))))
(catch 'exit
(while (re-search-backward drawer-re beg t)
--
2.1.4
--
http://www.cse.org.uk/about-us/staff#Tom-Hinton
- [O] Fix for clocking in when org-clock-into-drawer is not a string,
Tom Hinton <=