Re: [O] Cookies on check-boxed plain lists don't get updated

[Gerald Wildgruber]

Hi Nicolas,

thanks for the fix! The sub list cookie does get updated now, perfect!


Yet, check out this example from p.57 of the Org Manual (ch. "Checkboxes"):

* TODO Organize party [2/4]
 - [-] call people [1/3]
   - [ ] Peter
   - [X] Sarah
   - [ ] Sam
 - [X] order food
 - [ ] think about what music to play
 - [X] talk to the neighbors

With the new code now this gives:

* TODO Organize party [3/7]
 - [-] call people [1/3]
   - [ ] Peter
   - [X] Sarah
   - [ ] Sam
 - [X] order food
 - [ ] think about what music to play
 - [X] talk to the neighbors


Per default, the count now happens through ALL levels irrespective of
hierarchy ("organize party now has SEVEN sub tasks, not FOUR).

So the default behavior with regard to
"org-checkbox-hierarchical-statistics" has changed.

Manual: "Each cookie covers checkboxes of direct children structurally
below the headline/item on which the cookie appears. Set the option
org-checkbox-hierarchical-statistics if you want such cookies to count
all checkboxes below the cookie, not just those belonging to direct
children."

Perhaps it should be reflected in the Manual also.

Thanks again for your quick help!

Gerald.


On Mo, Aug 10 2015, Nicolas Goaziou <address@hidden> wrote:

> Hello,
>
> Gerald Wildgruber <address@hidden> writes:
>
>> Hi Rasmus,
>>
>> thanks for your hint, indeed this particular commit changed the
>> check-box related algorithm; "git log" gives:
>>
>> commit a4cc9d82d8069741be64c55f35f9d3ad7e2663d5
>> Author: Nicolas Goaziou <address@hidden>
>> Date:   Tue Jun 9 17:06:17 2015 +0200
>>
>>     org-list: Fix checkbox update with inlinetasks
>>     
>>     * lisp/org-list.el (org-update-checkbox-count): Change algorithm.  Use
>>       Element parser.
>>     
>>     * testing/lisp/test-org-list.el (test-org-list/update-checkbox-count):
>>       New test.
>>
>>
>> I then looked at this particular file's git log:
>>
>> git log lisp/org-list.el
>>
>> and checked out Nicolas' last revision BEFORE his commit on Tue Jun 9:
>>
>> git checkout a0c1e490b30cc4c0dd9e9ecdd70c32a52b08a57e lisp/org-list.el
>>
>> And indeed: everything works again as expected.
>>
>> Nicolas, can you see what caused this regression and can it be fixed?
>
> Fixed. Thanks to Rasmus and you.
>
> Regards,