Re: [O] [PATCH] org-timer.el: Use hh:mm:ss format instead of minutes

[Nicolas Goaziou]

Brice Waegenire <address@hidden> writes:

> Thanks for help on this!
> Here is the last version of the patch taking into account all of your
> comments.

Thank you.

>                    (read-from-minibuffer
> -                   "How many minutes left? "
> -                   (if (not (eq org-timer-default-timer 0))
> -                       (number-to-string org-timer-default-timer))))))
> +                   "How much time left? (minutes or h:mm:ss) "
> +                   (when (not (string-equal org-timer-default-timer "0"))

Nitpick: `unless'

> +                       (eval org-timer-default-timer))))))

Since `org-timer-default-timer' is a string, there's no need to eval it.

BTW, did you sign FSF papers already? If not, you need to add TINYCHANGE
to the end of the commit message.


Regards,