Re: [O] replace letf with cl-letf in org-mime

[Eric Abrahamsen]

Nicolas Goaziou <address@hidden> writes:

> Eric Abrahamsen <address@hidden> writes:
>
>> If I remove the two `eval's and treat "hook" like a normal variable, the
>> call to `length' fails with:
>>
>> Wrong type argument: sequencep, org-mime-pre-org-hook
>>
>> So apparently `length' is seeing the symbol name, and not the symbol
>> value.
>
> Indeed.
>
>> I tried changing the `let' to look like:
>>
>> (let ((hook (symbol-value (intern (....
>
> What about (length (symbol-value hook)) instead?
>
>> Here's a fixed version of the previous patch.
>
> Thank you. Applied.
>
>> I suppose I could also alter the "bhook" thing to use `symbol-value'
>> instead of `eval', but that doesn't seem to be a net gain.
>
> IMO, anything is a net gain compared to using `eval'.

Makes sense -- here's a fix for that.

Eric

0001-org-mime.el-Avoid-use-of-eval.patch
Description: Text Data