emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [patch, koma-letter] Change of subject behavior


From: Rasmus
Subject: Re: [O] [patch, koma-letter] Change of subject behavior
Date: Thu, 19 Mar 2015 12:35:58 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

Hi Nicolas,

Excellent comments.  Thanks a lot!

Nicolas Goaziou <address@hidden> writes:

> In this case, I suggest to change `org-koma-letter--special-headline'
> into `org-koma-letter--special-tag'

I agree.

> Eventually, since you're only interested in the first special tag
> encountered, it may be cleaner to exit early, e.g.,

Good idea.  I did it slightly differently with a funcall, but perhaps it's
slower (I have no idea).

>> +   (format "\\opening{%s}\n\n"
>> +       (org-export-data
>> +        (or (org-string-nw-p (plist-get info :opening))
>> +            (when (plist-get info :with-headline-opening)
>> +              (org-element-map (org-element-parse-buffer) 'headline
>                                    ^^^^^^^^^^^^^^^^^^^^^^^^^
>                                   (plist-get info :parse-tree)

Thanks.  I *knew* it was fishy.

—Rasmus

-- 
Hooray!

Attachment: 0003-ox-koma-letter-Interpret-SUBJECT.patch
Description: Text Data

Attachment: 0002-ox-koma-letter-Stricter-subject-inference.patch
Description: Text Data

Attachment: 0001-ox-koma-letter-Tiny-refactor.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]