Re: [O] Custom agenda shows all TODO

[Ken Mankoff]

On 2015-03-07 at 06:13, Ken Mankoff <address@hidden> wrote:
> Has something in the Agenda changed recently? I'm using Org from git
> and since upgrading my refresh Agenda behaves differently. I've
> searched the mailing list but found no mention of this. I know there
> were some 8.2 to 8.3 changes. Is this one of them?
>
> I have this in my custom agenda:
>
>     (todo "INPROGRESS" ((org-agenda-overriding-header "In Progress")))
>
> And when I load that Agenda, I see only TODO items with status
> "INPROGRESS".
>
> If I press "r" in a different section, I still see what I expect.
>
> But oddly if I press "r" in the "In Progress" section, then it
> refreshes and shows me *all* TODO items, not just INPROGRESS TODO
> items.

I've traced this issues (bug?) to a change between ba544e4 and d92ef95. I'm not 
sure what change, but the issue is in the agenda, and the diff for 
org-agenda.el is:


@@ -4789,7 +4789,7 @@ for a keyword.  A numeric prefix directly selects the Nth 
keyword in
       (or org-agenda-multi (org-agenda-fit-window-to-buffer))
       (add-text-properties (point-min) (point-max)
                           `(org-agenda-type todo
-                                            org-last-args ,arg
+                                            org-last-args (,arg)
                                             org-redo-cmd 
,org-agenda-redo-command
                                             org-series-cmd ,org-cmd))
       (org-agenda-finalize)



I have tested it with this MWE, used between those two git versions (checkout, 
make autoloads, and C-c C-x ! in a clean Emacs org buffer loaded with only 
this):


(add-to-list 'load-path "~/local/src/org-mode/lisp")
(add-to-list 'load-path "~/local/src/org-mode/contrib" t)
(require 'org)
(setq org-directory "~/Documents/Org")
(setq org-agenda-files (quote ("~/Documents/Org/"))
(define-key global-map "\C-ca" 'org-agenda)
(setq org-agenda-custom-commands
      '(
        ("c" "My Custom Agenda"
         (
          (todo "INPROGRESS")
          ))))


And then "r" after loading the custom agenda shows *all* TODO items, not just 
INPROGRESS TODO items.

  -k.