emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] New patches WAS Re: [PATCH] inline src block results can be remo


From: Charles C. Berry
Subject: Re: [O] New patches WAS Re: [PATCH] inline src block results can be removed
Date: Sun, 18 Jan 2015 19:22:36 -0800
User-agent: Alpine 2.00 (OSX 1167 2008-08-23)

On Fri, 16 Jan 2015, Nicolas Goaziou wrote:

"Charles C. Berry" <address@hidden> writes:

I've attached three patches and two files that show the behavior under
the current master (12 Jan 2015,
e0879b03d08bb4acc663084076370482f61e8698) and under the patched
version.

Thank you. Some comments follow.


[snip]


I don't think inline Babel blocks should be able to generate lists or
tables. Org cannot contain inline lists or tables. If you need a real
table or list, a regular Babel call will do.

I suggest to ignore :results table and :results list, or even return an
error, since this is bound to breaking the document structure.


OK. Now those cases (and some others) insert `*Inline error:' and a
comment as to what the error is and ignore the actual value.

Based on my own experience, I thought it best to allow Babel to run without stopping when there are problems with inline src blocks rather than stop with an error.

[snip]


I think the "protect commas and backslashes commas" should be factored
out of "ob-core.el" (and "org-element.el") and moved into
"org-macro.el".


OK.

I hope the approach I took modifies `org-macro-expand'.

The "as-is" template returns the macro element :value stripped of the leading "{{{<name>(" and the trailing "[\n]?)}}}". The template allows macros that mark text - possibly including commas - but do not modify it.

I am not sure why you mentioned org-element.el.

[snip]

Other comments from Nicolas 16 Jan email are addresed in the attached patches.

These patches address inline babel calls and apply the same logic to them.

A file with examples is attached.

n.b. the patch prefix numbers are 0002-0005.

HTH,

Chuck

Attachment: 0002-lisp-ob-core.el-Inline-source-block-babel-call-resul.patch
Description: ob-core.el patch

Attachment: 0003-ob-exp.el-Enable-removal-of-results.patch
Description: ob-exp.el patch

Attachment: 0004-lisp-ox.el-Enable-removable-inline-src-results.patch
Description: ox.el patch

Attachment: 0005-org-macro.el-Implement-an-identity-macro.patch
Description: org-macro.el patch

Attachment: inline-examples.org
Description: some examples


reply via email to

[Prev in Thread] Current Thread [Next in Thread]