Re: [O] [PATCH] Patches for agenda exiting commands

[Nicolas Goaziou]

Hello,

Kyle Meyer <address@hidden> writes:

> I've attached a few patches related to the agenda exiting commands.

Thank you. I applied patches 1, 2 and 3.

> Subject: [PATCH 4/5] org-agenda: Track last indirect buffer
>
> * lisp/org-agenda.el (org-agenda-tree-to-indirect-buffer): Record last
>   indirect buffer for agenda.
> * lisp/org-agenda.el (org-agenda-quit): Delete window for
>   org-agenda-last-indirect-buffer, not org-last-indirect-buffer.
>
> If an indirect buffer for an Org subtree was present as a window,
> org-agenda-quit deleted this window regardless of whether it was created
> from the agenda.  Introduce a new variable,
> org-agenda-last-indirect-buffer, that is specific for the agenda (and
> perhaps a particular agenda buffer, if org-agenda-sticky is set).
>
> org-agenda-quit checked for indirect buffers while org-agenda-Quit did
> not.  There doesn't seem to be any reason for this difference in
> behavior, so make org-agenda-Quit treat windows for indirect buffers the
> same way as org-agenda-quit.

Nitpick: in commit messages, prefer the present tense.

> +(defvar org-agenda-last-indirect-buffer nil)

Please provide a docstring for this new variable.

> Subject: [PATCH 5/5] org-agenda: Fix issues with restoring windows
>
> * lisp/org-agenda.el (org-agenda-prepare-window): Update window
>   configuration even when agenda buffer exists in background.
> * lisp/org-agenda.el (org-agenda-Quit): Use buffer value for
>   org-agenda-pre-window-conf to allow for local values used with sticky
>   agenda buffers.
> * lisp/org-agenda.el (org-agenda-quit): Reset local, not global, value for
>   org-agenda-pre-window-conf.
>
> The pre-agenda window configuration was not being updated, resulting in
> a window configuration other than the one prior to the most recent
> agenda call being restored, in the following cases:
>
> - The user exited or buried the buffer without using q, Q, or x.
> - org-agenda-sticky was non-nil and the user buried the buffer with q.
>   This was because the global, not buffer-local, value for
>   org-agenda-pre-window-conf was not being reset.
>
> Also, when org-agenda-sticky was non-nil, pressing Q (org-agenda-Quit)
> restored the global, not the buffer-local, value for
> org-agenda-pre-window-conf.
>
> Along with these changes, merge the duplicated functionality in
> org-agenda-quit and org-agenda-Quit.

Present tense, please.

Also, the commit message lacks the creation of `org-agenda--quit'.

Regards,

-- 
Nicolas Goaziou