emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATH] Speedups to org-table-recalculate


From: Nicolas Goaziou
Subject: Re: [O] [PATH] Speedups to org-table-recalculate
Date: Sat, 06 Dec 2014 00:57:37 +0100

Nathaniel Flath <address@hidden> writes:

> Sorry, that was incorrect - real patches attached.

Thanks.

> +(defun org-table-message-once-per-second (t1 &rest args)
> +  "If there has been more than one second since T1, display message.
> +ARGS are passed as arguments to the 'message' function.  Returns
> +current time if a message is printed, otherwise returns t1..  If
> +T1 is nil, always messages."
> +  (let ((curtime (current-time)))
> +    (when (or (not t1) (< 0 (nth 1 (time-subtract curtime t1))))
> +      (apply message args)
> +      curtime))
> +    t1)

The docstring seems incorrect, as the function always returns T1, no
matter if a message is printed or not.

> +         (setq log-last-time
> +               (org-table-message-once-per-second
> +                (when all log-last-time)

Nitpick: (and all log-last-time)

> +              (when all log-last-time)

Ditto.
> +         (when all log-first-time)

Ditto.


Regards,



reply via email to

[Prev in Thread] Current Thread [Next in Thread]