emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [RFC] Change property drawer syntax


From: Puneeth Chaganti
Subject: Re: [O] [RFC] Change property drawer syntax
Date: Fri, 5 Dec 2014 20:03:04 +0530

Hi Nicolas,

It looks the commit 8d8ad983823c63b13fd6b471ce9db8c2f95e3808 broke
generation of org sparse trees, when searching with properties that
are not all uppercase.   The fix seems to be just removing the
conversion of key to upcase in `org-entry-properties'.  Since the
comparison with special properties is being done by a case insensitive
check, this should be the only fix required?  There are no test
failures, and the conversion to uppercase seems to have been
introduced only in this change, so it should be OK?

diff --git a/lisp/org.el b/lisp/org.el
index e806440..8cbbcc4 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -15703,7 +15703,7 @@ strings."
                    ;; after its extension.  We also forbid standard
                    ;; properties to be named as special properties.
                    (while (re-search-forward org-property-re end t)
-                     (let* ((key (upcase (org-match-string-no-properties 2)))
+                     (let* ((key (org-match-string-no-properties 2))
                             (extendp (org-string-match-p "\\+\\'" key))
                             (key-base (if extendp (substring key 0 -1) key))
                             (value (org-match-string-no-properties 3)))

Thanks,
Puneeth



reply via email to

[Prev in Thread] Current Thread [Next in Thread]