Re: [O] [PATCH RFC] subtree archive hook?

[Eric Abrahamsen]

Aaron Ecay <address@hidden> writes:

> Hi Eric,
>
> 2014ko urriak 12an, Eric Abrahamsen-ek idatzi zuen:
>>> 
>>> Can the above inlinetask thing also be moved into the hook?  That
>>> seems cleaner, and gives another demonstration of the usefulness of
>>> the feature.
>> 
>> Here's a patch that does it, though I'm a little more cautious about
>> this since I only did a minimal test.
>> 
>> Two things that worry me: 1) why is it called "remove-END-maybe" when it
>> appears to remove the whole inlinetask, and 2) it its original habitat
>> in org-attach, it came after the call to org-cut-subtree, meaning that
>> it couldn't have operated on the subtree to be archived at all! Or am I
>> misunderstanding something? 
>
> No, you’re not misunderstanding – I was.  Indeed, the inline task stuff
> has to come after the call to org-cut-subtree, so it’s not a candidate
> for inclusion in the new hook.
>
> (What happens is that org-cut-subtree removes the inline task headline and
> any contents, leaving a bare *** END line.  The latter is subsequently
> cleaned up by the org-inlinetask-remove-END-maybe call.)

Yup, I figured it out after another few minutes of staring at it. No
harm done, I guess!