emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions s


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] org.el: make org-paragraph-fill ignore \[...\] regions starting and ending a line
Date: Thu, 28 Aug 2014 12:10:51 +0200

Hello,

Federico Beffa <address@hidden> writes:

> In any case, I've updated my git repository (less than 24h ago) and
> recreated the patch. I've tested it and believe it is working. Why
> don't you give it a try. It's not such a disruptive change.

I looked at the patch. You are still applying it on maint, while the
function in /master/ branch is different. If you look at it, you will
see there are simple ways to achieve what you want (i.e no need for
3 helper functions and 80 additional locs).

Also, I think your implementation is still ill-defined. Consider the
following case:

 Paragraph with a very very ... long line \[some
 math\]

IIUC, M-q should fill the math snippet since it doesn't start nor end
lines. However, if I add text, e.g. additional "very" in the first line,
auto-filling will eventually move "\[some" to the next line, leading to

 Paragraph with a very very very very ... long line
 \[some
 math\]

which cannot be filled since, this time, "\[" starts a line and "\]"
ends one. This math snippet is at the same time fillable and
un-fillable. Schrödinger's snippet. IOW, you also need to prevent
"\[some" to be moved to a new line on its own.


Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]