emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minte


From: Aaron Ecay
Subject: Re: [O] [RFC] [PATCH] ox-latex: support :float no with caption for minted listings
Date: Sat, 23 Aug 2014 16:27:07 -0400
User-agent: Notmuch/0.18.1+51~gbbbdf04 (http://notmuchmail.org) Emacs/24.4.50.2 (x86_64-unknown-linux-gnu)

Hi Nicolas,

2014ko abuztuak 23an, Nicolas Goaziou-ek idatzi zuen:
> 
> Hello,
> 
> Aaron Ecay <address@hidden> writes:
> 
>> * lisp/ox-latex.el (org-latex-src-block): Support :float no with
>> caption for minted.
>> (org-latex-listings): Edit docstring to describe this usecase.
> 
> There is already :float nil, which is documented in the manual.

You’re right – this was confusion on my part induced by babel header
args, which use yes and no instead of t and nil.  I’ll fix it.

> 
>> +            (cond ((and (string= "no" float) caption)
>> +                   (format "%%s\n%s" (replace-regexp-in-string
>> +                                      "\\\\caption" "\\captionof{listing}"
>> +                                      caption-str t t)))
> 
> I think this should be a (trivial) filter. Is there any reason to
> support "captionof" package out of the box?

It’s not adding any new functionality to the exporter, but rather
covering one particular combination of already-existing options (caption
provided, :float nil, org-latex-listings = minted) that does not produce
sensible output presently.  Should I fix the nil/no issue and send a new
patch?

Thanks for your feedback,

-- 
Aaron Ecay



reply via email to

[Prev in Thread] Current Thread [Next in Thread]