Re: [O] [PATCH] ob-shell

Me again,

Please forget about the previous patch I submitted, I have a new one that should work now on all platforms.

Let me know if it should be formatted differently.

I will also add some more tests to check that such arrays in bash are handled properly when the input contains whitespace, quotes, commas and other chars that one may have to deal with.

--paf

On Fri, Aug 22, 2014 at 10:52 AM, Pascal Fleury <address@hidden> wrote:

Hello,

I have a little patch (attached) that does check the version of bash, and uses associative arrays (or doesn't) depending on that version.

The problem now is that the test suite will only work on one platform t a time, i.e. if there is a bash4 there, it will pass, but if it has bash3, it will work as intended, but return a different value set. Is there a way to have platform-dependent tests ?

--Pascal

On Wed, Aug 13, 2014 at 3:29 PM, Alan Schmitt <address@hidden> wrote:

On 2014-08-13 15:20, Pascal Fleury <address@hidden> writes:

> Yes, sorry for late reaction (it's holiday season here :-).

Funny, it's holiday season here as well (in Bretagne) ;-)

> This is an issue I introduced with the assoc. arrays, which does not
> verify if the installed version of bash handles them (from bash4 on).
> It needs a modification in the setup code that checks the version and
> only issues assoc. array code when bash supports it. And it so happens
> that Macs have bash3 installed. Will try to find such a machine and
> add the test.

Thanks a lot. If I can help, please let me know.

Best,

Alan

--
OpenPGP Key ID : 040D0A3B4ED2E5C7

--
--paf

--
--paf

From:	Pascal Fleury
Subject:	Re: [O] [PATCH] ob-shell
Date:	Fri, 22 Aug 2014 15:08:35 +0200