Re: [O] [PATCH] ob-shell

[Pascal Fleury]

Yes, sorry for late reaction (it's holiday season here :-).

This is an issue I introduced with the assoc. arrays, which does not verify if the installed version of bash handles them (from bash4 on).

It needs a modification in the setup code that checks the version and only issues assoc. array code when bash supports it. And it so happens that Macs have bash3 installed. Will try to find such a machine and add the test.

--paf

On Wed, Aug 13, 2014 at 3:12 PM, Alan Schmitt <address@hidden> wrote:

On 2014-08-04 21:48, Achim Gratz <address@hidden> writes:

> Alan Schmitt writes:
>> Has this been applied? I'm still seeing a failing test for ob-shell.
>>
>> 1 unexpected results:
>>    FAILED  ob-shell/bash-uses-assoc-arrays
>
> That's to be expected if you use a version of bash that doesn't support
> assoc arrays.

I don't use bash, I either use zsh or fish. So I guess the version of
bash on my system is the one that ships with OS X 10.9:

GNU bash, version 3.2.51(1)-release (x86_64-apple-darwin13)

> WHat is the backtrace from the test?  Babel (and the
> tests) blindly assume that these things work when they see you using
> "bash".

Test ob-shell/bash-uses-assoc-arrays backtrace:
  signal(ert-test-failed (((should (equal "20 cm" (org-babel-execute-s
  ert-fail(((should (equal "20 cm" (org-babel-execute-src-block))) :fo
  (if (unwind-protect (setq value-1098 (apply fn-1096 args-1097)) (set
  (let (form-description-1100) (if (unwind-protect (setq value-1098 (a
  (let ((value-1098 (quote ert-form-evaluation-aborted-1099))) (let (f
  (let ((fn-1096 (function equal)) (args-1097 (list "20 cm" (org-babel
  (save-restriction (org-babel-next-src-block 2) (let ((fn-1096 (funct
  (progn (org-id-goto "82320a48-3409-49d7-85c9-5de1c6d3ff87") (setq to
  (unwind-protect (progn (org-id-goto "82320a48-3409-49d7-85c9-5de1c6d
  (let ((save-match-data-internal (match-data))) (unwind-protect (prog
  (progn (let ((save-match-data-internal (match-data))) (unwind-protec
  (unwind-protect (progn (let ((save-match-data-internal (match-data))
  (let ((wconfig (current-window-configuration))) (unwind-protect (pro
  (unwind-protect (let ((wconfig (current-window-configuration))) (unw
  (let* ((id-location (org-id-find "82320a48-3409-49d7-85c9-5de1c6d3ff
  (lambda nil (let* ((id-location (org-id-find "82320a48-3409-49d7-85c
  byte-code("\306\307!q\210\310\216\311 \312\216\313\314\315\316\3
  ert--run-test-internal([cl-struct-ert--test-execution-info [cl-struc
  byte-code("\306\307!\211\211r\310\311!q\210\312 d\313\223)L\210)\3
  ert-run-test([cl-struct-ert-test ob-shell/bash-uses-assoc-arrays "Ba
  ert-run-or-rerun-test([cl-struct-ert--stats "\\(org\\|ob\\)" [[cl-st
  ert-run-tests("\\(org\\|ob\\)" #[(event-type &rest event-args) "\306
  ert-run-tests-batch("\\(org\\|ob\\)")
  ert-run-tests-batch-and-exit("\\(org\\|ob\\)")
  (let ((org-id-track-globally t) (org-test-selector (if org-test-sele
  org-test-run-batch-tests("\\(org\\|ob\\)")
  eval((org-test-run-batch-tests org-test-select-re))
  command-line-1(("--eval" "(setq vc-handled-backends nil org-startup-
  command-line()
  normal-top-level()
Test ob-shell/bash-uses-assoc-arrays condition:
    (ert-test-failed
     ((should
       (equal "20 cm"
              (org-babel-execute-src-block)))
      :form
      (equal "20 cm" "50 dl")
      :value nil :explanation
      (array-elt 0
                 (different-atoms
                  (50 "#x32" "?2")
                  (53 "#x35" "?5")))))
   FAILED  104/510  ob-shell/bash-uses-assoc-arrays

Thanks,

Alan

--
OpenPGP Key ID : 040D0A3B4ED2E5C7

--
--paf