emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [patch] [babel] Patches to fix tangling and variable transfer of


From: Rainer M Krug
Subject: Re: [O] [patch] [babel] Patches to fix tangling and variable transfer of tables in R
Date: Tue, 08 Jul 2014 12:23:45 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (darwin)

Rainer M Krug <address@hidden> writes:

Just to ping these patches for application.

Cheers,

Rainer


> Nicolas Goaziou <address@hidden> writes:
>
>> Hello,
>>
>> Rainer M Krug <address@hidden> writes:
>>
>>> Attached please find two patches ready for application to fix that table
>>> variables were not usable adter tangling as temporary files were used.
>>> These patches were discussed in the thread "[babel][PATCHES] ob-R
>>> patches for review"
>>
>> I have not much to say about the feature, since I don't use R. Usual
>> nitpicking follows.
>>
>>> +    (if (integerp value) (format "%s <- %s" name (concat (number-to-string 
>>> value) "L"))
>>> +      (if (floatp value) (format "%s <- %s" name value)
>>> +   (if (stringp value) (format "%s <- %S" name value) 
>>> +     (format "%s <- %S" name (prin1-to-string value)))))))
>>
>> I think a `cond' would be more readable here.
>
> Amended patches attached.
>
>>
>>
>> Regards,

-- 
Rainer M. Krug, PhD (Conservation Ecology, SUN), MSc (Conservation Biology, 
UCT), Dipl. Phys. (Germany)

Centre of Excellence for Invasion Biology
Stellenbosch University
South Africa

Tel :       +33 - (0)9 53 10 27 44
Cell:       +33 - (0)6 85 62 59 98
Fax :       +33 - (0)9 58 10 27 44

Fax (D):    +49 - (0)3 21 21 25 22 44

email:      address@hidden

Skype:      RMkrug

PGP: 0x0F52F982

Attachment: pgptyUVqB7u6Q.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]