emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] -for review- Tangling with variable transfer of variable


From: Aaron Ecay
Subject: Re: [O] [PATCH] -for review- Tangling with variable transfer of variables
Date: Sat, 21 Jun 2014 23:39:09 -0400
User-agent: Notmuch/0.17+160~g03680d1 (http://notmuchmail.org) Emacs/24.4.50.1 (x86_64-unknown-linux-gnu)

Hi Rainer,

2014ko ekainak 21an, "Charles C. Berry"-ek idatzi zuen:
> 
> On Fri, 20 Jun 2014, Rainer M Krug wrote:
> 
>> Attached please find =the reworked patch.
>> 
>> 1) uses local() and closes connection
>> 2) does not leave a variable cal;led file behind
>> 
> 
> Seems to work on a few test cases.
> 
> I'd move the strings to defconsts.
> 
> Putting a newline before each `%S' will outdent the first line of 
> :var value when it is echoed in the session log so it will be easier to 
> view.

+1 to both of the above suggestions but otherwise the patch looks good
and I think it should be applied.

-- 
Aaron Ecay



reply via email to

[Prev in Thread] Current Thread [Next in Thread]