Re: [O] [babel][PATCHES] ob-R patches for review

[Charles Berry]

Rainer M Krug <Rainer <at> krugs.de> writes:

> 
> Hi
> 
> Attached please find seven patches for review to implement the storing
> of org variables in their own environment and to make the org-issued R
> code look nicer in the R session.


Rainer,


I have suggestions and a concern.

I suggest that you look at how ESS handles R objects and constructs
calls in elisp to be executed in an R session.

It uses a package and its NAMESPACE to provide that functionality and
store objects. That makes the elisp interface a lot cleaner and keeps
ESS variables out of the users way. The package is found at <ESS>/etc/ESSR/.

I also suggest that you introduce a customization variable to
allow a user to turn off the functionality you have created.

My concern is that you are injecting code into the R user session or
script that the user may not want. If I already have an R object named
'org' your code will break my code.

Further, all of this is hard coded, so I can't change the
variable/file names.

HTH,

Chuck