Re: [O] [PATCH] Improve message when file to include is missing

[Sebastien Vauban]

Hello Nicolas,

Nicolas Goaziou wrote:
> "Sebastien Vauban" writes:
>
>> This should answer your (fruitful) comments.
>
> Thank you for the update.
>
> It looks good.

Thanks.

> AFAIC, you can push it.

I don't have (yet) push access...

>> +    (if (or (not file) (not (file-readable-p file)))
>> +    (if (not noerror)
>> +        (error "Cannot read file \"%s\"%s" file info-from-file)
>> +      (message "Cannot read file \"%s\"%s" file info-from-file))
>> +      (with-temp-buffer
>> +    (insert-file-contents file)
>> +    (buffer-string)))))
>
> Minor stylistic issue: I find the following a bit easier to understand.
>
>   (if (and file (file-readable-p file))
>       (with-temp-buffer
>         (insert-file-contents file)
>         (buffer-string))
>     (funcall (if noerror #'message #'error)
>              "Cannot read file \"%s\"%s" file info-from-file))

So do I...

Best regards,
  Seb

-- 
Sebastien Vauban