emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes


From: Rasmus
Subject: Re: [O] [PATCH][ox-koma-letter] changed-in-buffer, subject, minor fixes
Date: Sat, 25 Jan 2014 14:44:48 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Nicolas,

Nicolas Goaziou <address@hidden> writes:

> Rasmus <address@hidden> writes:
>
>> Nicolas Goaziou <address@hidden> writes:
>>
>>>> I finally had the time to fix these old patches.  Sorry about the
>>>> wait.
>>>
>>> You should update Org first. I modified large parts of ox-koma-letter.el
>>> recently so your patches will probably not apply. Also, some parts are
>>> not necessary anymore.
>>
>> I did. . .  And I formatted the patch against origin/master.  I'll
>> look into it.  Thanks.
>
> After a cursory look, it seems that patches 1 and 2 are not necessary
> anymore. I didn't tackle down subject vs title issue, so patch 3 is
> needed. Though, I think it needs some changes to be applied.

Would you give the attached patches a spin?  I think they work nicely;
only the second patch is non-trivial.  Basically, one can ignore
subject and title differences as now by setting
org-koma-letter-prefer-subject to t and not use the SUBJECT keyword.

I have set the default of -prefer-subject to nil per the discussion
with Alan and Michael Strey.

It should apply against master.

–Rasmus

-- 
Dung makes an excellent fertilizer

Attachment: 0001-Documentation-fixes-for-ox-koma-script.el.patch
Description: Text Data

Attachment: 0002-Allow-separate-subject-and-title-in-ox-koma-letter.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]