emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] Add ob-J.el


From: Bastien
Subject: Re: [O] [PATCH] Add ob-J.el
Date: Fri, 20 Dec 2013 17:13:30 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Hi Oleh,

Oleh <address@hidden> writes:

> Here's a patch to add babel support for J.

Thanks.  Are you a FSF-signed contributor?  We cannot include
this in Org's core without your copyright assignment, let me know.

> I couldn't figure out how to make ob-J.elc a target for make,
> maybe someone can fix this.

No need to create a specific target.

Some comments on the code below:

> From 0139af8534dc33911ed1a24a9702a156ae46c99d Mon Sep 17 00:00:00 2001
> From: Oleh Krehel <address@hidden>
> Date: Fri, 20 Dec 2013 14:43:59 +0100
> Subject: [PATCH] Add org-babel support for J.
>
> ---
>  lisp/ob-J.el | 134 
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 134 insertions(+)
>  create mode 100644 lisp/ob-J.el
>
> diff --git a/lisp/ob-J.el b/lisp/ob-J.el
> new file mode 100644
> index 0000000..50c1a5a
> --- /dev/null
> +++ b/lisp/ob-J.el
> @@ -0,0 +1,134 @@
> +;;; ob-J.el --- org-babel functions for J evaluation
> +
> +;; Copyright (C) 2011-2013 Free Software Foundation, Inc.
> +
> +;; Author: Oleh Krehel
> +;; Keywords: literate programming, reproducible research
> +;; Homepage: http://orgmode.org
> +
> +;; This file is part of GNU Emacs.

That's for Org's core (the lisp/ directory) but we can add
ob-J.el in contrib/lisp/ without the copyright assignment.

> +  (mapconcat #'identity (split-string body "\n") "\necho''\n"))
                ^

(mapconcat 'identity ...)

is fine.

> +(defun org-babel-J-strip-whitespace (str)
> +(defun obj-strip-leading-ws (s)

Maybe you can use org-trim here.

> +;;; ob-J.el ends here

Thanks for this contribution!

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]