emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ox-html: Restore wrongly omitted table attributes under


From: Nicolas Goaziou
Subject: Re: [O] [PATCH] ox-html: Restore wrongly omitted table attributes under HTML5.
Date: Sun, 30 Jun 2013 00:37:33 +0200

Hello,

Kodi Arfer <address@hidden> writes:

> From edd97671641e28c3e240efe6ea8fa8d77b4b7eae Mon Sep 17 00:00:00 2001
> From: Kodi Arfer <address@hidden>
> Date: Sat, 29 Jun 2013 10:43:07 -0400
> Subject: [PATCH] ox-html: Restore wrongly omitted table attributes under
>  HTML5.
>
> * lisp/ox-html.el (org-html-table): For HTML5,
>   omit :html-table-attributes but not :id or :attr_html.

Thank you for your patch. Could you rebase it against "maint"? I cannot
apply it at the moment.

> +            (unless (org-html-html5-p info)
> +              (plist-get info :html-table-attributes))

One nitpick. It is more explicit to use:

  (and (not (org-html-html5-p info))
       (plist-get info :html-table-attributes))

since you are using the returned value.


Regards,

-- 
Nicolas Goaziou



reply via email to

[Prev in Thread] Current Thread [Next in Thread]