Re: [O] bug(?) ox-html always add a timestamp in comment which can't be customized away

[Nick Dokos]

Haojun Bao <address@hidden> writes:

> Just checked, it is the same tag (release_8.0.3), there is no change like in 
> your code.
>
> Could you please run git blame on those lines?

You need to upgrade to latest. Git blame says:

,----
| $ git blame -L 1509,1511 lisp/ox-html.el
| d574bf52 (Kodi Arfer 2013-05-30 15:19:57 -0400 1509)      (when (plist-get 
info :time-stamp-file)
| d574bf52 (Kodi Arfer 2013-05-30 15:19:57 -0400 1510)        
(format-time-string
| d574bf52 (Kodi Arfer 2013-05-30 15:19:57 -0400 1511)   (concat "<!-- " 
org-html-metadata-timestamp-format " -->\n")))
`----

and the commit shows the change from the code you see to the code I see:

,----
| address@hidden:~/src/emacs/org/org-mode$ git show d574bf52
| commit d574bf522d1b2ac74cb4245f8742253bde7861df
| Author: Kodi Arfer <address@hidden>
| Date:   Thu May 30 15:19:57 2013 -0400
| 
|     ox-html: Fix handling of time-stamp-file
|     
|     * lisp/ox-html.el (org-html--build-meta-info): Insert no timestamp
|       when :time-stamp-file is nil.
|     
|     TINYCHANGE
| 
| diff --git a/lisp/ox-html.el b/lisp/ox-html.el
| index 297cb55..949c3ba 100644
| --- a/lisp/ox-html.el
| +++ b/lisp/ox-html.el
| @@ -1506,10 +1506,9 @@ INFO is a plist used as a communication channel."
|                    "iso-8859-1")))
|      (concat
|       (format "<title>%s</title>\n" title)
| -     (format
| -      (when :time-stamp-file
| -     (format-time-string
| -      (concat "<!-- " org-html-metadata-timestamp-format " -->\n"))))
| +     (when (plist-get info :time-stamp-file)
| +       (format-time-string
| +      (concat "<!-- " org-html-metadata-timestamp-format " -->\n")))
|       (format
|        (if (org-html-html5-p info)
|         (org-html-close-tag "meta" " charset=\"%s\"" info)
`----

Nick

>
> On Sat, Jun 8, 2013 at 1:30 PM, Nick Dokos <address@hidden> wrote:
>
>     Haojun Bao <address@hidden> writes:
>    
>     > The culprit code is the following:
>     >
>     >   (when :time-stamp-file
>     >     (format-time-string
>     >      (concat "<!-- " org-html-metadata-timestamp-format " -->\n")))
>     >
>     > This `when' condition is always true, because :time-stamp-file is a
>     > keyword and always eval to itself, never to nil.
>     >
>     > So I think org-export-time-stamp-file should be used instead of
>     > :time-stamp-file.
>     >
>    
>     What version are you using? In the version I have, the code looks like
>     this:
>    
>          (when (plist-get info :time-stamp-file)
>            (format-time-string
>              (concat "<!-- " org-html-metadata-timestamp-format " -->\n")))
>    
>     Org-mode version 8.0.3 (release_8.0.3-197-g221768)
>     [nb: this version includes a few local commits (irrelevant to this 
> subject)]
>     --
>     Nick
>

-- 
Nick