Re: [O] [PATCH (v3)][ox-latex.el] Allow AUTO argument to org-latex-guess-babel-language.

[Nicolas Goaziou]

Hello,

Rasmus <address@hidden> writes:

> Nicolas Goaziou <address@hidden> writes:

> is the attached patch better?

It is, thank you. Here is another round of comments.

> +     (replace-match (mapconcat 'identity
> +                               (if language
> +                                   (cond ((member language options)
> +                                          (delete "AUTO") options)
> +                                         ((member "AUTO" options)
> +                                          (dotimes (n (length options) 
> options)
> +                                            (if (equal "AUTO" (nth n 
> options))
> +                                                (setf (nth n options) 
> language))))
> +                                         (t (append options (list 
> language))))
> +                                 (delete "AUTO" options))

I suggest to use something like this instead:

  (mapconcat (lambda (option) (if (equal "AUTO" option) language option))
             (cond ((member language options) (delete "AUTO" options))
                   ((member "AUTO" options) options)
                   (t (append options (list language)))))

> -                      nil nil header 1))))))
> +                               t nil header 1)))))

Why do you need to use a non-nil FIXEDCASE argument here?


Regards,

-- 
Nicolas Goaziou