[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [O] RFQ - new contribution - org-screenshot.el
From: |
Bastien |
Subject: |
Re: [O] RFQ - new contribution - org-screenshot.el |
Date: |
Fri, 17 May 2013 15:49:18 +0200 |
User-agent: |
Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) |
Hi Max,
Max Mikhanosha <address@hidden> writes:
> My list is.
>
> 1. Convert defvar to defcustom
>
> 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in
> dired.el
Seems fine to me.
> 3. The prefix C-c M-s seems awkward but Org is so big everything else
> is taken, and C-c C-x s is too close to C-c C-x C-s, which is
> archive subtree (I initially had it there and moved after archiving
> subtree by mistake)
I'd favor reserving C-c C-x for core packages, and use anything else
for contrib/ packages.
> Its its fine to go in as is, then its fine too, I'm pretty lazy :-)
Whatever sounds more practical to you! You can include it now,
have more eyes watching (after) your code, then feel the pressure
to overcome the laziness in implementing the above :)
--
Bastien
Re: [O] RFQ - new contribution - org-screenshot.el, Feng Shu, 2013/05/17
Re: [O] RFQ - new contribution - org-screenshot.el, Max Mikhanosha, 2013/05/17
Re: [O] RFQ - new contribution - org-screenshot.el, François Pinard, 2013/05/20
Re: [O] RFQ - new contribution - org-screenshot.el, Russell Adams, 2013/05/20