emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[O] [PATCH] Honor properties in derived backends with default nil


From: Viktor Rosenfeld
Subject: [O] [PATCH] Honor properties in derived backends with default nil
Date: Tue, 14 May 2013 19:04:01 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Hi,

the attached patch fixes the problem. I wasn't sure if the logic simply
reverts the changes in commit 16f12e0 but it passes the test suite.

Cheers,
Viktor

Viktor Rosenfeld wrote:

> Hi,
> 
> commit 16f12e0 changed how the EMAIL option is configured in a derived
> exporter that also uses this keyword.
> 
> In `contrib/ox-koma-letter.el', the koma-letter exporter configures the 
> default
> of the EMAIL option to the variable `org-koma-letter-email'. However, since
> commit 16f12e0, if the option is missing, the default is set to
> `user-mail-address' which is the default for the standard LaTeX exporter.
> 
> The current code causes the following bug in koma-letter exporter: If EMAIL is
> missing, and `org-koma-letter-email' is `nil', then the exporter should not 
> set
> a email address in the exported LaTeX file. The rationale is that the email
> address is configured in an external LCO file (and can be overwritten for an
> individual letter, if desired). However, the new behavior causes the email to
> be set explicitly, overwriting the value from the LCO file.
> 
> Consider the following example:
> 
> #+BEGIN_SRC org
> #+LATEX_CLASS: my-letter
> #+LCO: DefaultAddress
> #+END_SRC
> 
> The expected LaTeX-code is:
> 
> #+BEGIN_SRC latex
> \documentclass{scrlttr2}
> \LoadLetterOption{DefaultAddress}    % <--- email is set here
> % ...
> \begin{document}
> % ...
> \end{document}
> #+END_SRC
> 
> However, since commit 16f12e0, the generated code is:
> 
> #+BEGIN_SRC latex
> \documentclass{scrlttr2}
> \LoadLetterOption{DefaultAddress}    % <--- email is set here
> address@hidden  % <--- email is overwritten here
> % ...
> \begin{document}
> % ...
> \end{document}
> #+END_SRC
> 
> Is this a bug in the LaTeX exporter or is this the intended behavior? Should I
> maybe use another keyword instead of EMAIL? I think I used SENDER instead of
> AUTHOR because of a similar conflict.
> 
> Cheers,
> Viktor

Attachment: 0001-ox.el-Honor-properties-in-derived-backends-with-defa.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]