emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH] ox-html: Ensure space between tag and attribute when clo


From: Lawrence Mitchell
Subject: Re: [O] [PATCH] ox-html: Ensure space between tag and attribute when closing tags
Date: Tue, 07 May 2013 18:58:22 +0100
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

Bastien wrote:
> Hi Lawrence,

> Lawrence Mitchell <address@hidden> writes:

>> * lisp/ox-html.el (org-html-close-tag): Add space before attr.

> thanks for the patch -- can you make it against the maint branch
> so that we include this in the next minor release?  It does not
> apply against master.

It won't apply against maint because the ox-html changes that
introduced the problem (9bc55c, Export to various flavors of
(X)HTML) are on master, not maint.

My patch definitely applies against master:

$ git checkout master
$ git describe
release_8.0.2-91-g29ab1bb
$ git am ...
$ git diff origin/master
diff --git c/lisp/ox-html.el w/lisp/ox-html.el
index 05b99bf..0379567 100644
--- c/lisp/ox-html.el
+++ w/lisp/ox-html.el
@@ -1301,7 +1301,7 @@ CSS classes, then this prefix can be very useful."
        (member dt '("html5" "xhtml5" "<!doctype html>"))))
 
 (defun org-html-close-tag (tag attr info)
-  (concat "<" tag (or attr "")
+  (concat "<" tag " " attr
          (if (org-html-xhtml-p info) " />" ">")))
 
 (defun org-html--make-attribute-string (attributes)


-- 
Lawrence Mitchell <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]